Entity Actions: More create button discernible text, extension of #20434 #20458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as `actions_viewActionsFor` already existed. Also made into a function, to support a fallback label.
Removed the need for a `getCreateAriaLabel()` method.
as the "umb-entity-actions-bundle" component handles this now.
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-element-base.ts
leekelleher
approved these changes
Oct 13, 2025
leekelleher
added a commit
to umbraco/Umbraco.Playwright.Testhelpers
that referenced
this pull request
Oct 13, 2025
This is to support PR umbraco/Umbraco-CMS#20458
This comment was marked as resolved.
This comment was marked as resolved.
nhudinh0309
pushed a commit
to umbraco/Umbraco.Playwright.Testhelpers
that referenced
this pull request
Oct 13, 2025
* Language menu locate exact label text This is to support PR umbraco/Umbraco-CMS#20458 * Bump version number
andr317c
added a commit
to umbraco/Umbraco.Playwright.Testhelpers
that referenced
this pull request
Nov 3, 2025
* Add helper: for property action, dashboard (#294) * Add helper for property action * add dashboard helper * Update lib/helpers/UiBaseLocators.ts Co-authored-by: Nhu Dinh <[email protected]> * Bumped version --------- Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Nhu Dinh <[email protected]> Co-authored-by: Nhu Dinh <[email protected]> * Add helper: for block custom view (#299) * add helper for block custom view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/DataTypeApiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * change locator * Fix parameter name * add verson and format code * fix conflict --------- Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Nhu Dinh <[email protected]> * Add helper: for workspace view (#298) * Add helper: for workspace view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * move method into UiBaseLocators * update version --------- Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Nhu Dinh <[email protected]> * V16: Updates Language menu label locator (#300) * Language menu locate exact label text This is to support PR umbraco/Umbraco-CMS#20458 * Bump version number * add new version (#302) Co-authored-by: Lan Nguyen Thuy <[email protected]> * V16 Cherrypick changes from 17 (#311) * Updated helpers * Bumped version * Add helper: for custom collection view (#313) * add helper for custom collection view * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * Update lib/helpers/ContentUiHelper.ts Co-authored-by: Nhu Dinh <[email protected]> * update some names --------- Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Nhu Dinh <[email protected]> * V16 reverted updates from 17 (#314) * Updated helpers * Bumped version --------- Co-authored-by: NguyenThuyLan <[email protected]> Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Lee Kelleher <[email protected]> Co-authored-by: Andreas Zerbst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add-on to #20434
Added new localization key for the rest of the sections in the backoffice, such as Users, Members, dictionary and settings sections.
The other ticket was merged, so I'm not sure if this creates conflicts making another like this. Let me know if I should somehow add it to the other one @leekelleher 😎👍🏼